Make the rust_no_allocation backend deterministic #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hchataing
reviewed
Nov 10, 2023
Having non-deterministic generated sources means that incremental builds would have extra recompilations. Also pretty-print the generated code.
Colecf
force-pushed
the
deterministic_rust_generation
branch
from
d9c2ac4 to
2802478
Compare
hchataing
approved these changes
Nov 10, 2023
jrguzman-ms
pushed a commit
to msft-mirror-aosp/platform.build.soong
that referenced
this pull request
Nov 11, 2023
These genrules work with sandboxing already, they just had non-determinism that lead genrule_sandboxing.py to think that they didn't. Non-determinism sources include: - HeadlessBuildTimestamp literally just generates a header file with a timestamp, not much we can do here other than re-architect their code. - Pdlc has a non-determinism issue I sent out a cl to fix: google/pdl#85 - Python tools write the command they were ran with to generated files, and non-embedded-launcher python scripts have non-deterministic paths. Switched to embedded_launcher: true: aosp/2825231 - In addition, the path to the genrule sandbox is not non-deterministic, but it is a hash of the inputs to the sandbox. When running genrule_sandbox.py, it compares a "partial" sandbox (which only sandboxes tools) to a "full" sandbox, and these two runs have different sandbox hashes. Bug: 307824623 Test: Presubmits Change-Id: Ib966262dc1aac99a0798f26d8a03966cc97fe1bf
pure-soul-kk
pushed a commit
to Project-Elixir/build_soong
that referenced
this pull request
Mar 15, 2024
These genrules work with sandboxing already, they just had non-determinism that lead genrule_sandboxing.py to think that they didn't. Non-determinism sources include: - HeadlessBuildTimestamp literally just generates a header file with a timestamp, not much we can do here other than re-architect their code. - Pdlc has a non-determinism issue I sent out a cl to fix: google/pdl#85 - Python tools write the command they were ran with to generated files, and non-embedded-launcher python scripts have non-deterministic paths. Switched to embedded_launcher: true: aosp/2825231 - In addition, the path to the genrule sandbox is not non-deterministic, but it is a hash of the inputs to the sandbox. When running genrule_sandbox.py, it compares a "partial" sandbox (which only sandboxes tools) to a "full" sandbox, and these two runs have different sandbox hashes. Bug: 307824623 Test: Presubmits Change-Id: Ib966262dc1aac99a0798f26d8a03966cc97fe1bf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having non-deterministic generated sources means that incremental builds would have extra recompilations.
Also pretty-print the generated code.
The non-determinism was discovered in some android modules like bluetooth_core_rust_packets