-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use lockfile scalibr interface #1330
Draft
another-rex
wants to merge
114
commits into
google:main
Choose a base branch
from
another-rex:use-lockfile-scalibr-interface
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat: Use lockfile scalibr interface #1330
another-rex
wants to merge
114
commits into
google:main
from
another-rex:use-lockfile-scalibr-interface
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…extractor is updated.
another-rex
force-pushed
the
use-lockfile-scalibr-interface
branch
from
October 22, 2024 06:11
438b655
to
e45f30a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains all the code required to move to osv-scalibr while making the existing code compile and pass all tests (container tests not passing because of a bug in the scalibr alpine extractor).
Changes not mentioned in the following list will be split off in separate PRs which should land before this PR.
Changes in this PR:
internal/lockfilescalibr
package:errors.go
adds common extraction errors we want to translate.translation.go
adds helper functions and translation logic between osv-scanner v1 extractor names, and osv-scalibr extractor names.Changes in followup PRs: