Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datasource/graphene) added timestamp tool to graphene, timestamp property to SegmentationUserLayer #613

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chrisj
Copy link
Contributor

@chrisj chrisj commented Jul 15, 2024

replaces #587

This is also designed to support our future cave annotation layers being able to synchronize/control with the segmentation timestamp.

Here is part of that implementation seung-lab@4d41b32

…ies a new timestamp property on SegmentationUserLayer
@chrisj
Copy link
Contributor Author

chrisj commented Jul 15, 2024

Also, can you explain what you use to organize imports? Is it using the eslintrc.yml file? The default vs code sorter wants to sort lowercase above all uppercase imports and doesn't have the same behavior with package and css imports.

@jbms
Copy link
Collaborator

jbms commented Oct 31, 2024

You can use npm run format:fix and npm run lint:fix --- it is indeed eslint.

@jbms
Copy link
Collaborator

jbms commented Oct 31, 2024

Can you explain the logic of timestampOwner? It looks like the purpose is to link the timestamp across layers, but why canSetTimestamp?

@chrisj
Copy link
Contributor Author

chrisj commented Nov 1, 2024

I'm currently using timestamp owner to do a self-lock when our graphene layer has an active edit tool (owner = self + no timestamp). canSetTimestamp says you to change the timestamp when there is no owners or the only owner is the one checking. Alternatively, I could make a setter function for timestamp that does the check and also sets owner.

The cave annotation datasource has more use of timestamp owner. I plan to put up a PR for if this PR is approved.
seung-lab@5dd2b7d

The cave annotation layers have a timestamp associated with it, when it gets linked to a segmentation layer, it sets the segmentation layer to the same timestamp if possible. Multiple annotation layers with the same timestamp can be linked to the same segmentation layer. Each one gets added as an owner. Only once all of them are unlinked is the segmentation timestamp available to be changed (or if one remaining owner wants to change the timestamp it has ownership of).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants