Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix annotation value array type on native&js target #1508

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

qdsfdhvh
Copy link

@qdsfdhvh qdsfdhvh commented Aug 25, 2023

on nativie & js target, when annotation value array type, result is Array<*>, I tried removed the throw and save it.

fix #1487, fix #1503

@google-cla
Copy link

google-cla bot commented Aug 25, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Contributor

@neetopia neetopia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The exception is meant to avoid silent failures, can you keep the throw statement, and add one more else if before the last else clause to address this case?

@qdsfdhvh
Copy link
Author

qdsfdhvh commented Sep 8, 2023

I've considered else if before, but I'm not sure how to write it, I tried to add a judgement about method.returnType and result::class.type, how about that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants