Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AA: implement asMemberOf #1496

Merged
merged 6 commits into from
Aug 18, 2023
Merged

AA: implement asMemberOf #1496

merged 6 commits into from
Aug 18, 2023

Conversation

neetopia
Copy link
Contributor

In this PR:

  • implements asType and starProjectedType for enum entries
  • fillup misc apis on value parameter
  • implements getDeclarationByName APIs
  • fork test data for nestedClassType test (new behavior seems more correct with type annotation included).
  • implement asMemberOf
    • currently still not working:
    • function substitution is not working with transitive parameters
    • type parameter boundaries not rendered with substitution
  • add Any to unbounded type parameter

Copy link
Collaborator

@ting-yuan ting-yuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please comment on what's changed for forked tests in commit messages.

@TestMetadata("nestedClassType.kt")
@Test
fun testNestedClassType() {
runTest("../test-utils/testData/api/nestedClassType.kt")
runTest("testData/nestedClassType.kt")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please comment on what is changed in the commit message.

AA's behavior includes type annotation which looks more
correct than FE1.0.
@neetopia neetopia merged commit 5bc2f16 into google:main Aug 18, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants