fill up implementations for expect/actuals

google · Sep 13, 2023 · ba26305 · ba26305
1 parent b25a6da
commit ba26305
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 18 deletions.
diff --git a/...main/kotlin/com/google/devtools/ksp/impl/symbol/kotlin/KSClassDeclarationEnumEntryImpl.kt b/...main/kotlin/com/google/devtools/ksp/impl/symbol/kotlin/KSClassDeclarationEnumEntryImpl.kt
@@ -109,20 +109,6 @@ class KSClassDeclarationEnumEntryImpl private constructor(private val ktEnumEntr
 
     override val annotations: Sequence<KSAnnotation> = emptySequence()
 
-    override val isActual: Boolean
-        get() = TODO("Not yet implemented")
-
-    override val isExpect: Boolean
-        get() = TODO("Not yet implemented")
-
-    override fun findActuals(): Sequence<KSDeclaration> {
-        TODO("Not yet implemented")
-    }
-
-    override fun findExpects(): Sequence<KSDeclaration> {
-        TODO("Not yet implemented")
-    }
-
     override val declarations: Sequence<KSDeclaration> by lazy {
         // TODO: fix after .getDeclaredMemberScope() works for enum entry with no initializer.
         emptySequence()

diff --git a/...ysis-api/src/main/kotlin/com/google/devtools/ksp/impl/symbol/kotlin/KSExpectActualImpl.kt b/...ysis-api/src/main/kotlin/com/google/devtools/ksp/impl/symbol/kotlin/KSExpectActualImpl.kt
@@ -19,19 +19,27 @@ package com.google.devtools.ksp.impl.symbol.kotlin
 import com.google.devtools.ksp.symbol.KSDeclaration
 import com.google.devtools.ksp.symbol.KSExpectActual
 import org.jetbrains.kotlin.analysis.api.symbols.KtDeclarationSymbol
+import org.jetbrains.kotlin.analysis.api.symbols.markers.KtPossibleMultiplatformSymbol
 
 class KSExpectActualImpl(private val declarationSymbol: KtDeclarationSymbol) : KSExpectActual {
     override val isActual: Boolean
-        get() = TODO("Not yet implemented")
+        get() = (declarationSymbol as? KtPossibleMultiplatformSymbol)?.isActual == true
 
     override val isExpect: Boolean
-        get() = TODO("Not yet implemented")
+        get() = (declarationSymbol as? KtPossibleMultiplatformSymbol)?.isExpect == true
 
+    // TODO: not possible in new KMP model, returning empty sequence for now.
     override fun findActuals(): Sequence<KSDeclaration> {
-        TODO("Not yet implemented")
+        return emptySequence()
     }
 
     override fun findExpects(): Sequence<KSDeclaration> {
-        TODO("Not yet implemented")
+        return if (!isActual) {
+            emptySequence()
+        } else {
+            analyze {
+                declarationSymbol.getExpectForActual()?.toKSDeclaration()
+            }?.let { sequenceOf(it) } ?: emptySequence()
+        }
     }
 }