Migrated kCTF from Google Container Registry to Artifact Registry #406
Conversation
| @@ -166,7 +166,7 @@ function push_image { | |||
|
|
|||
| case "${CLUSTER_TYPE}" in | |||
| gce) | |||
| IMAGE_URL="${REGISTRY}/${PROJECT}/${CHALLENGE_NAME}-${IMAGE_NAME}:${IMAGE_ID}" | |||
| IMAGE_URL="${REGISTRY}/${PROJECT}/${CLUSTER_NAME}-${CHALLENGE_NAME}/${IMAGE_NAME}:${IMAGE_ID}" | |||
There was a problem hiding this comment.
Is there a difference between slashes here? Maybe just add slashes too, for consistency.
There was a problem hiding this comment.
There is a significance to the slashes, it's a path that gets parsed.
Although, some want the path to be more like:
IMAGE_URL="${REGISTRY}/${PROJECT}/challenges/${CLUSTER_NAME}-${CHALLENGE_NAME}-${IMAGE_NAME}:${IMAGE_ID}"
There was a problem hiding this comment.
What if we have a dash in the cluster? Wouldn't that cause a collision?
There was a problem hiding this comment.
the registry should be shared by all challenges, so we can create it in kctf cluster create rather than managing several in kctf challenge. I used IMAGE_URL="${REGISTRY}/${PROJECT}/${CLUSTER_NAME}/${CHALLENGE_NAME}-${IMAGE_NAME}:${IMAGE_ID}"
should registry creation be part of this PR? Container Registry is shutting down very soon
| @@ -95,7 +95,7 @@ function _kctf_complete_chal() { | |||
| # This will be out of date at some point, but still useful so worth it? | |||
| # We can't fetch it easily with gcloud unfortunately since it requires a project | |||
| GCP_REGIONS="us-east1-b us-east1-c us-east1-d us-east4-c us-east4-b us-east4-a us-central1-c us-central1-a us-central1-f us-central1-b us-west1-b us-west1-c us-west1-a europe-west4-a europe-west4-b europe-west4-c europe-west1-b europe-west1-d europe-west1-c europe-west3-c europe-west3-a europe-west3-b europe-west2-c europe-west2-b europe-west2-a asia-east1-b asia-east1-a asia-east1-c asia-southeast1-b asia-southeast1-a asia-southeast1-c asia-northeast1-b asia-northeast1-c asia-northeast1-a asia-south1-c asia-south1-b asia-south1-a australia-southeast1-b australia-southeast1-c australia-southeast1-a southamerica-east1-b southamerica-east1-c southamerica-east1-a asia-east2-a asia-east2-b asia-east2-c asia-northeast2-a asia-northeast2-b asia-northeast2-c asia-northeast3-a asia-northeast3-b asia-northeast3-c asia-southeast2-a asia-southeast2-b asia-southeast2-c europe-north1-a europe-north1-b europe-north1-c europe-west6-a europe-west6-b europe-west6-c northamerica-northeast1-a northamerica-northeast1-b northamerica-northeast1-c us-west2-a us-west2-b us-west2-c us-west3-a us-west3-b us-west3-c us-west4-a us-west4-b us-west4-c" | |||
| GCP_REGISTRIES="gcr.io asia.gcr.io eu.gcr.io us.gcr.io" | |||
| GCP_REGISTRIES="pkg.dev docker.pkg.dev" | |||
There was a problem hiding this comment.
This should include the zones I think
Container Registry is deprecated and scheduled for shutdown. After May 15, 2024, Artifact Registry will host images for the gcr.io domain in Google Cloud projects without previous Container Registry usage. After March 18, 2025, Container Registry will be shut down.