Make AtomicReferenceFieldUpdater fields static for [better performance](https://shipilev.net/blog/2015/faster-atomic-fu/#:~:text=thrown%20out%20of%20the%20window).
#7606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_712965455
branch
from
6d3f8fb to
9f23c14
Compare
…mance](https://shipilev.net/blog/2015/faster-atomic-fu/#:~:text=thrown%20out%20of%20the%20window). This may eliminate the reason for [an `Unsafe`-based implementation](#6806) even under Java 8, but we will ideally confirm that with benchmarks before ripping that implementation out. (There's also Android: `AtomicReferenceFieldUpdater` is available there, but we should look into performance, including under older versions, especially with AFAIK no plans to remove `Unsafe` there.) (Also, make a few other tiny edits to the backport copy so that it matches the mainline copy more closely.) RELNOTES=n/a PiperOrigin-RevId: 713006636
copybara-service
bot
force-pushed
the
test_712965455
branch
from
9f23c14 to
400af25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
AtomicReferenceFieldUpdaterfieldsstaticfor better performance.This may eliminate the reason for an
Unsafe-based implementation even under Java 8, but we will ideally confirm that with benchmarks before ripping that implementation out. (There's also Android:AtomicReferenceFieldUpdateris available there, but we should look into performance, including under older versions, especially with AFAIK no plans to removeUnsafethere.)(Also, make a few other tiny edits to the backport copy so that it matches the mainline copy more closely.)
RELNOTES=n/a