Update BloomFilterStrategies.java #7550
Open
+10
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove imul instruction from murmur operations of 32bit hash functions -- reduces the number of instructions by 1 CPU cycle. Before -- https://godbolt.org/z/GWvnEoPa3 After -- https://godbolt.org/z/4zEoM5G1W
|
I see the difference in bytecode, but is there a difference in benchmarks? I'd tend to expect both versions to get optimized to the same thing. |
|
yeah, running a BM is good idea. By any chance, do we have one for testing the performance of the strategies ?. if so, could you please point me out on how to run them. thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove imul instruction from murmur operations of 32bit hash functions -- reduces the overall number of instructions by ~1-3 CPU cycles.
Before -- https://godbolt.org/z/ed93nf1sx
After -- https://godbolt.org/z/3h1rG399P