Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix link to AMD docs #68

Merged
merged 2 commits into from
Aug 10, 2023
Merged

fix link to AMD docs #68

merged 2 commits into from
Aug 10, 2023

Conversation

datosh
Copy link
Contributor

@datosh datosh commented Aug 3, 2023

Link has changed

@deeglaze deeglaze closed this Aug 5, 2023
@datosh
Copy link
Contributor Author

datosh commented Aug 7, 2023

@deeglaze why did you close the PR? Is the link working for you, or anything missing for it to be merged?

@deeglaze deeglaze reopened this Aug 7, 2023
@deeglaze
Copy link
Collaborator

deeglaze commented Aug 7, 2023

Sorry, I must have closed this in my sleep. There's another wp-content link in verify/trust/trust.go that should be fixed as well. Would you change that one too, please?

Signed-off-by: Fabian Kammel <[email protected]>
@datosh
Copy link
Contributor Author

datosh commented Aug 8, 2023

PTAL @deeglaze
I am not sure what the other dead link served before. From the name ask_ark_milan.cert I suspect it is the same as VCEK chain.

@deeglaze
Copy link
Collaborator

deeglaze commented Aug 9, 2023

It is not the same. The contents are in the SEV ABI format for public keys. The link is also broken in AMD's repo, which I propose a fix here: https://github.com/AMDESE/sev-guest/pull/42/files

Signed-off-by: Fabian Kammel <[email protected]>
@deeglaze deeglaze merged commit e24f408 into google:main Aug 10, 2023
8 checks passed
@deeglaze
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants