client.GetQuoteProvider: return error if none supported #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Meyer <[email protected]>
|
This is by design. It's only meant to fall back to the ioctl provider if the configfs provider isn't available yet. The error in the signature was just to match go-tdx-guest, which also doesn't return an error. It's something to fix in the next major version upgrade. I don't mind this change though. I'll approve and merge if you still want it. |
deeglaze
approved these changes
Aug 15, 2024
I think checking for support of config-tsm and returning an error early is a good idea, even after removing the ioctl provider. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, support for IoctlQuoteProvider isn't checked and returned error is always nil.