Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add root certs for Genoa #127

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Conversation

Freax13
Copy link
Contributor

@Freax13 Freax13 commented Jul 8, 2024

This PR adds the root ASK/ARK certs for Genoa. I'm not sure if AMD also distributes the certificates for Genoa in the older sevcert format we use for Milan, so I used the newer x509-based certificates instead.

Copy link

google-cla bot commented Jul 8, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Freax13
Copy link
Contributor Author

Freax13 commented Jul 9, 2024

The CI failure seems to be unrelated to this PR and already happened in previous CI runs: https://github.com/google/go-sev-guest/actions/runs/8993363579/job/24705035892.

@deeglaze
Copy link
Collaborator

deeglaze commented Jul 9, 2024

I've updated the protoc github action in #128 so please rebase and try again. I'll work on getting it merged today.

verify/trust/trust.go Show resolved Hide resolved
Co-authored-by: Dionna Amalie Glaze <[email protected]>
@Freax13
Copy link
Contributor Author

Freax13 commented Jul 10, 2024

@deeglaze Now CI is failing because you haven't signed the CLA for the main E-Mail address linked to your GitHub account (i.e. the E-Mail address GitHub added a Co-authored-by tag for when I committed your suggestion).

@Freax13 Freax13 requested a review from deeglaze July 10, 2024 08:32
@deeglaze deeglaze merged commit 64e2ff0 into google:main Jul 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants