Allow certentry Validate to fail before error #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deeglaze
requested review from
pgonda and
google-ospo-team
and removed request for
google-ospo-team
kongoshuu
approved these changes
Feb 21, 2024
If a certificate is missing, the blob will be nil on lookup. This changes the contract with Validate to allow nil blobs to mean "try to fetch this yourself" in the case that the evidence is not present locally but its location can possibly be inferred from the report.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a certificate is missing, the blob will be nil on lookup. This changes the contract with Validate to allow nil blobs to mean "try to fetch this yourself" in the case that the evidence is not present locally but its location can possibly be inferred from the report.