fix: Stop lying how GRPC renders durations #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by reporting the data types and formats that are actually used Fixes: google#351
nightlyone
force-pushed
the
fix/io/align_duration_documentation_with_implementation
branch
from
8ee62cb
to
c06885a
Compare
timburks
approved these changes
Aug 25, 2023
There was a problem hiding this comment.
@nightlyone thanks, this is great. It adds more detail than we have for the other well-known types, but I think we should just take that as a call to improve the others.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by reporting the data types and formats that are actually used for google.protobuf.Duration
Fixes: #351