Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md for Windows on CLI Tool section #162

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

elviscapiaq
Copy link
Collaborator

No description provided.

README.md Outdated Show resolved Hide resolved
@angela28chen
Copy link
Collaborator

To be honest I think the whole https://github.com/google/dive?tab=readme-ov-file#cli-tool-for-capture-and-cleanup section currently has redundant code blocks about how to build android libraries and how to build the CLI host tool. Would it be a better idea to just link to the relevant sections rather than repeat that? The unique info in this section seems to be starting around ninja install and the following steps of how to use the dive_client_cli

RenfengLiu
RenfengLiu previously approved these changes Jan 17, 2025
@elviscapiaq
Copy link
Collaborator Author

To be honest I think the whole https://github.com/google/dive?tab=readme-ov-file#cli-tool-for-capture-and-cleanup section currently has redundant code blocks about how to build android libraries and how to build the CLI host tool. Would it be a better idea to just link to the relevant sections rather than repeat that? The unique info in this section seems to be starting around ninja install and the following steps of how to use the dive_client_cli

I updated the CLI tool for capture section. Thanks.

@elviscapiaq elviscapiaq merged commit 000ca03 into google:main Jan 17, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants