Add presubmit configuration for BazelCI #195
Conversation
This change adds the configuration for BazelCI, as described at `https://github.com/bazelbuild/continuous-integration`. Note that this also runs on postsubmit.
|
Since this repo isn't in the bazelbuild org and doesn't contain any bazel rules set, I don't think the Bazel team will want to run the CI on their managed system. I'd suggest we switch to CircleCI, this is what all the Angular projects use. Can I help write a config for that? |
|
+1 would greatly appreciate
…On Fri, Oct 25, 2019, 7:31 AM Alex Eagle ***@***.***> wrote:
Since this repo isn't in the bazelbuild org and doesn't contain any bazel
rules set, I don't think the Bazel team will want to run the CI on their
managed system.
I'd suggest we switch to CircleCI, this is what all the Angular projects
use. Can I help write a config for that?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#195?email_source=notifications&email_token=AA2MCGYJ73UWDTF6NNLJGE3QQL7K5A5CNFSM4IYOOYKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECIRB5Q#issuecomment-546377974>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA2MCGZVWQHJMGRTJW3QWT3QQL7K5ANCNFSM4IYOOYKA>
.
|
Add presubmit configuration for BazelCI This will let us build and test soy on github, which we can then use to validate that the bazel files actually work. GITHUB_BREAKING_CHANGES=n/a ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=273777510
|
This is merged |
|
@iteriani Thanks! @alexeagle I can see your point, but I also think there's a value in having this repo as part of Bazel's incompatible and/or downstream pipeline (and there are lots of similar cases on Bazel CI, e.g. Abseil, Cartographer, Cloud Robotics, Envoy, ...). Taking your comment on bazelbuild/rules_closure#436 (comment) into consideration, I think one could make a point to create the (not-yet-existing) Bazel worker for soy in this repo and maybe move soy-rules here as well (and only load+export them in rules_closure). |
This change adds the configuration for BazelCI, as described at
https://github.com/bazelbuild/continuous-integration.Note that this also runs on postsubmit.