support multiple event factories #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zxzxwu
approved these changes
Jan 6, 2025
zxzxwu
reviewed
Jan 6, 2025
| if cls.vendor_factory: | ||
| if event := cls.vendor_factory(parameters): | ||
| for vendor_factory in cls.vendor_factories: | ||
| if event := vendor_factory(parameters): | ||
| return event | ||
|
|
||
| # No factory, or the factory could not create an instance, |
There was a problem hiding this comment.
Should here return HCI_Vendor_Event instead of HCI_Event?
There was a problem hiding this comment.
Yes. Done. I've also added a test for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While there's no way to ensure the uniqueness of HCI vendor event codes across vendors, it is still possible to have vendor event factories that don't overlap (by design), such as the generic set of Android vendor HCI events which multiple vendors do implement (and in that case the vendors ensure that they don't re-use the same event codes for other events).
This change allows having multiple vendor factories, which will be invoked in registration order when an HCI vendor event is encountered, instead of a single factory. It is up to the caller to ensure that they do not register factories with overlapping IDs.