only use __bytes__
when not argument is needed.
#600
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of
to_bytes
should be reserved for cases where an argument is needed (likeint.to_bytes()
). For all other cases,__bytes__
should be used.For legacy reasons, the code base still had a few places where
to_bytes
was called (and classes where both__bytes__
andto_bytes
were defined).This PR cleans up these cases.