Support non-directed address generation offload #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@benquike @uael @hchataing It seems rootcanal doesn't handle address resolution offloading properly? |
|
Maybe the rootcanal is fine, but Bumble tries to add resolving list when there is active connection... |
|
zxzxwu
force-pushed
the
offload
branch
2 times, most recently
from
e8335b0 to
fffe24d
Compare
|
I just updated v1.6.0 of RootCanal to pypi. |
zxzxwu
force-pushed
the
offload
branch
3 times, most recently
from
136b131 to
527bc32
Compare
barbibulle
approved these changes
Jan 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address generation offloading uses peer address as an entry of IRK, even in non-directed usage. By adding an empty entry containing local IRK to controller resolving list, controllers are able to generate RPA without pairing.