Get number of CPUs with sysconf() on Linux #1901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid parsing the /proc/cpuinfo just to get number of CPUs. Instead use the portable function provided by glibc.
|
This is a follow-up patch to #1900 |
|
is this a relatively new addition or did i just not know about it when i started this? :) |
|
It's really old. Man-page mentions POSIX.1-2008 and POSIX.1-2001. Btw, the previous pull request (#1900) was completely OK, but it's sadly not sufficient to fix sparc64 buiid yet... |
|
clang-format would like some love please. the other failures are at HEAD. |
|
I dropped the leading space, as mentioned by clang test. |
dmah42
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid parsing the /proc/cpuinfo just to get number of CPUs. Instead use the portable function provided by glibc.