Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the kMaxIterations limit #1668

Merged
merged 7 commits into from
Oct 17, 2023
Merged

Increase the kMaxIterations limit #1668

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
970b757
Increase the kMaxIterations limit
andreas-abel Sep 20, 2023
dc6f720
Merge branch 'main' into time_simple
dmah42 Sep 26, 2023
7d37795
Merge branch 'main' into time_simple
dmah42 Sep 26, 2023
3205b96
Fix failing test on Windows
andreas-abel Oct 17, 2023
7a68cb8
Fix formatting
andreas-abel Oct 17, 2023
020c0ca
Merge branch 'main' into time_simple
dmah42 Oct 17, 2023
9ae06a3
Merge branch 'main' into time_simple
dmah42 Oct 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/benchmark_runner.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ MemoryManager* memory_manager = nullptr;

namespace {

static constexpr IterationCount kMaxIterations = 1000000000;
static constexpr IterationCount kMaxIterations = 1000000000000;
const double kDefaultMinTime =
std::strtod(::benchmark::kDefaultMinTimeStr, /*p_end*/ nullptr);

Expand Down Expand Up @@ -325,8 +325,8 @@ IterationCount BenchmarkRunner::PredictNumItersNeeded(

// So what seems to be the sufficiently-large iteration count? Round up.
const IterationCount max_next_iters = static_cast<IterationCount>(
std::lround(std::max(multiplier * static_cast<double>(i.iters),
static_cast<double>(i.iters) + 1.0)));
std::llround(std::max(multiplier * static_cast<double>(i.iters),
static_cast<double>(i.iters) + 1.0)));
// But we do have *some* limits though..
const IterationCount next_iters = std::min(max_next_iters, kMaxIterations);

Expand Down
Loading