Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in time convention application #169

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix bug in time convention application #169

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5625a6
Fix bug in time convention application
peter-dudbridge Jul 2, 2024
f36f310
fix typo
peter-dudbridge Jul 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions weatherbench2/schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,18 +29,18 @@ def apply_time_conventions(
forecast = forecast.copy()
if 'prediction_timedelta' in forecast.coords:
forecast = forecast.rename({'prediction_timedelta': 'lead_time'})
if by_init:
# Need to rename time dimension because different from time dimension in
# truth dataset
forecast = forecast.rename({'time': 'init_time'})
valid_time = forecast.init_time + forecast.lead_time
forecast.coords['valid_time'] = valid_time
assert not hasattr(
forecast, 'time'
), f'Forecast should not have time dimension at this point: {forecast}'
else:
init_time = forecast.time - forecast.lead_time
forecast.coords['init_time'] = init_time
if by_init:
# Need to rename time dimension because different from time dimension in
# truth dataset
forecast = forecast.rename({'time': 'init_time'})
valid_time = forecast.init_time + forecast.lead_time
forecast.coords['valid_time'] = valid_time
assert not hasattr(
forecast, 'time'
), f'Forecast should not have time dimension at this point: {forecast}'
else:
init_time = forecast.time - forecast.lead_time
forecast.coords['init_time'] = init_time
return forecast


Expand Down