Fix 121 ClangTidyBuild findings: #1034
Open
+148
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
* missing #include <string> for 'std::string' For more info see go/clang_tidy/checks/google3-build-missing-std-includes (33 times) * missing #include <vector> for 'std::vector' For more info see go/clang_tidy/checks/google3-build-missing-std-includes (23 times) * missing #include <utility> for 'std::move' For more info see go/clang_tidy/checks/google3-build-missing-std-includes (13 times) * missing #include <tuple> for 'std::tuple' For more info see go/clang_tidy/checks/google3-build-missing-std-includes (10 times) * missing #include <utility> for 'std::pair' For more info see go/clang_tidy/checks/google3-build-missing-std-includes (5 times) * missing #include <optional> for 'std::optional' For more info see go/clang_tidy/checks/google3-build-missing-std-includes (5 times) * missing #include <variant> for 'std::visit' For more info see go/clang_tidy/checks/google3-build-missing-std-includes (5 times) * missing #include <memory> for 'std::make_unique' For more info see go/clang_tidy/checks/google3-build-missing-std-includes (4 times) * missing #include <memory> for 'std::unique_ptr' For more info see go/clang_tidy/checks/google3-build-missing-std-includes (2 times) * missing #include <algorithm> for 'std::max' For more info see go/clang_tidy/checks/google3-build-missing-std-includes (2 times) * missing #include <algorithm> for 'std::sort' For more info see go/clang_tidy/checks/google3-build-missing-std-includes (2 times) * missing #include <ios> for 'std::ios' For more info see go/clang_tidy/checks/google3-build-missing-std-includes (2 times) * missing #include <iterator> for 'std::back_inserter' For more info see go/clang_tidy/checks/google3-build-missing-std-includes (2 times) * missing #include <string_view> for 'std::string_view' For more info see go/clang_tidy/checks/google3-build-missing-std-includes (2 times) * missing #include <system_error> for 'std::error_code' For more info see go/clang_tidy/checks/google3-build-missing-std-includes * missing #include <iterator> for 'std::inserter' For more info see go/clang_tidy/checks/google3-build-missing-std-includes * missing #include <map> for 'std::map' For more info see go/clang_tidy/checks/google3-build-missing-std-includes * missing #include <memory> for 'std::addressof' For more info see go/clang_tidy/checks/google3-build-missing-std-includes * missing #include <array> for 'std::array' For more info see go/clang_tidy/checks/google3-build-missing-std-includes * missing #include <cstring> for 'std::strerror' For more info see go/clang_tidy/checks/google3-build-missing-std-includes * missing #include <functional> for 'std::function' For more info see go/clang_tidy/checks/google3-build-missing-std-includes * missing #include <algorithm> for 'std::set_intersection' For more info see go/clang_tidy/checks/google3-build-missing-std-includes * missing #include <algorithm> for 'std::find' For more info see go/clang_tidy/checks/google3-build-missing-std-includes * missing #include <sstream> for 'std::ostringstream' For more info see go/clang_tidy/checks/google3-build-missing-std-includes * missing #include <variant> for 'std::variant' For more info see go/clang_tidy/checks/google3-build-missing-std-includes This CL looks good? Just LGTM and Approve it! This CL doesn’t look good? This is what you can do: * Revert this CL, by replying "REVERT: <provide reason>" * File a bug under go/clang-tidy-bug for category ClangTidyBuild if there's an issue with the CL content. * File a bug under go/rosie-bug if there's an issue with how the CL was managed. * For all other issues such as the formatting of the CL, please file a bug under go/clrobot-bug. * Revert this CL and not get a CL that cleans up these paths in the future by replying "BLOCKLIST: <provide reason>". This is not reversible! We recommend to opt out the respective paths in your CL Robot configuration instead: go/clrobot-opt-out. This CL was generated by CL Robot - a tool that cleans up code findings (go/clrobot). The affected code paths have been enabled for CL Robot in //depot/google3/METADATA by following go/clrobot#how-to-opt-in. Anything wrong with the signup? File a bug at go/clrobot-bug. #codehealth PiperOrigin-RevId: 707735012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix 121 ClangTidyBuild findings:
This CL looks good? Just LGTM and Approve it!
This CL doesn’t look good? This is what you can do:
go/clrobot-bug.
replying "BLOCKLIST: ". This is not reversible! We recommend to
opt out the respective paths in your CL Robot configuration instead:
go/clrobot-opt-out.
This CL was generated by CL Robot - a tool that cleans up code findings
(go/clrobot). The affected code paths have been enabled for CL Robot in //depot/google3/METADATA by
following go/clrobot#how-to-opt-in. Anything wrong with the signup? File a bug
at go/clrobot-bug.
#codehealth