-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go/packages: add TypesInfo properly when NeedTypesInfo was set while NeedSyntax & NeedTypes were not #536
base: master
Are you sure you want to change the base?
go/packages: add TypesInfo properly when NeedTypesInfo was set while NeedSyntax & NeedTypes were not #536
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This PR (HEAD: 38870bb) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/621015. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/621015. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/621015. |
Message from Chris Tang (潮生): Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/621015. |
Message from Michael Matloob: Patch Set 3: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/621015. |
This PR (HEAD: c053272) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/621015. Important tips:
|
Message from Chris Tang (潮生): Patch Set 5: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/621015. |
Fix when only NeedTypesInfo was set, no TypesInfo was produced.
Under most circumstances NeedTypesInfo should work the same as NeedTypes, since Types and TypesInfo are produced together (except for cases when ExportFiles were included).
Fixes #69931