-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/term: set missing VIRTUAL_TERMINAL_INPUT flag on Windows #17
Conversation
This PR (HEAD: 68e3ca0) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/term/+/603960. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/603960. |
Message from Laurent Demailly: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/603960. |
Message from Ian Lance Taylor: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/603960. |
Message from Laurent Demailly: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/603960. |
Message from Laurent Demailly: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/603960. |
Message from Alex Brainman: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/603960. |
Message from Laurent Demailly: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/603960. |
Message from Laurent Demailly: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/603960. |
Message from Laurent Demailly: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/603960. |
Message from Alex Brainman: Patch Set 5: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/603960. |
Message from Go LUCI: Patch Set 5: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-08-23T08:48:54Z","revision":"28757e401eec8d49371c43809472b50087436a61"} Please don’t reply on this GitHub thread. Visit golang.org/cl/603960. |
Message from Alex Brainman: Patch Set 5: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/603960. |
Message from Go LUCI: Patch Set 5: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/603960. |
Message from Go LUCI: Patch Set 5: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/603960. |
Message from Alex Brainman: Patch Set 5: Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/603960. |
Message from Alex Brainman: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/603960. |
Message from Cherry Mui: Patch Set 5: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/603960. |
With this change the arrow keys work with Windows 11 Terminal After verifying https://github.com/containerd/console did work fine, unlike x/term, it's because they have: https://github.com/containerd/console/blob/v1.0.4/console_windows.go#L194 using the same flag fixed x/term for my program Small e2e test reproducing the issue and showing it being fixed can be ran using go run fortio.org/terminal/[email protected] # has the fix (or @latest) go run fortio.org/terminal/[email protected] -history .history # does not have working arrow keys/this fix Fixes golang/go#68830 Change-Id: If20addd054c76b889a52f933695467812be72306 GitHub-Last-Rev: 68e3ca0 GitHub-Pull-Request: #17 Reviewed-on: https://go-review.googlesource.com/c/term/+/603960 LUCI-TryBot-Result: Go LUCI <[email protected]> Auto-Submit: Ian Lance Taylor <[email protected]> Reviewed-by: Cherry Mui <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]> Commit-Queue: Ian Lance Taylor <[email protected]> Reviewed-by: Alex Brainman <[email protected]>
This PR is being closed because golang.org/cl/603960 has been merged. |
With this change the arrow keys work with Windows 11 Terminal
After verifying https://github.com/containerd/console did work fine, unlike x/term, it's because they have:
https://github.com/containerd/console/blob/v1.0.4/console_windows.go#L194
using the same flag fixed x/term for my program
Small e2e test reproducing the issue and showing it being fixed can be ran using
go run fortio.org/terminal/[email protected] # has the fix (or @latest)
go run fortio.org/terminal/[email protected] -history .history # does not have working arrow keys/this fix
Fixes golang/go#68830