-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http2: add SETTINGS_ENABLE_CONNECT_PROTOCOL support #221
Conversation
This PR (HEAD: d1683ac) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/net/+/610977. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/610977. |
Message from Weidi Deng: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/610977. |
Message from Damien Neil: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/610977. |
This PR (HEAD: 77f622b) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/net/+/610977. Important tips:
|
77f622b
to
4e0170f
Compare
This PR (HEAD: 4e0170f) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/net/+/610977. Important tips:
|
This PR (HEAD: bccd6b9) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/net/+/610977. Important tips:
|
Message from Weidi Deng: Patch Set 4: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/610977. |
Message from Damien Neil: Patch Set 5: (5 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/610977. |
This PR (HEAD: 4aac677) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/net/+/610977. Important tips:
|
Message from Weidi Deng: Patch Set 5: (5 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/610977. |
Message from Damien Neil: Patch Set 6: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/610977. |
# Conflicts: # http2/transport_test.go
Message from Weidi Deng: Patch Set 6: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/610977. |
This PR (HEAD: cba5ecd) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/net/+/610977. Important tips:
|
Message from Damien Neil: Patch Set 7: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/610977. |
Message from Go LUCI: Patch Set 7: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-11-22T00:52:09Z","revision":"802423183e33825e36fc900ee7e99ef9c9d7cfbc"} Please don’t reply on this GitHub thread. Visit golang.org/cl/610977. |
Message from Damien Neil: Patch Set 7: Auto-Submit+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/610977. |
Message from Damien Neil: Patch Set 7: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/610977. |
Message from Go LUCI: Patch Set 7: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/610977. |
Message from Go LUCI: Patch Set 7: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/610977. |
Message from Damien Neil: Patch Set 7: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/610977. |
For golang/go#49918 Change-Id: Ibcd8fb189200c0976cf1bd03a796abae4afa4cfd GitHub-Last-Rev: cba5ecd GitHub-Pull-Request: #221 Reviewed-on: https://go-review.googlesource.com/c/net/+/610977 Reviewed-by: Damien Neil <[email protected]> Auto-Submit: Damien Neil <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Roland Shoemaker <[email protected]>
Message from Roland Shoemaker: Patch Set 7: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/610977. |
This PR is being closed because golang.org/cl/610977 has been merged. |
For golang/go#49918