This repository has been archived by the owner on Jun 27, 2023. It is now read-only.
record invocation arguments in generated code #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Uber maintainers.
This rewrites the import path from "github.com/golang/mock" to "go.uber.org/mock".
|
@codyoss please review |
Ran go mod tidy and removed a bunch of unused dependencies from go.sum. Ideally we should run this as part of some lint check step as we do in other uber-go repositories.
Update README to reflect: - current status - installation path - supported Go versions - Remove irrelevant info
from Go 1.19, `go fmt` reformats doc comments. https://go.dev/doc/go1.19#go-doc > Go 1.19 adds support for links, lists, and clearer headings in doc comments. As part of this change, [gofmt](https://go.dev/cmd/gofmt) now reformats doc comments to make their rendered meaning clearer. See “[Go Doc Comments](https://go.dev/doc/comment)” for syntax details and descriptions of common mistakes now highlighted by gofmt. As another part of this change, the new package [go/doc/comment](https://go.dev/pkg/go/doc/comment/) provides parsing and reformatting of doc comments as well as support for rendering them to HTML, Markdown, and text.
Go 1.18 is no longer supported. Now, we can bump Go version to 1.19.
- Bump checkout/setup-go actions versions - Drop pre-1.18 action - Edit action permissions to readonly
This preps v0.1.0 release. Added a CHANGELOG file to keep track of release changes according to semver. Ref golang#17.
Originally discussed in golang#238. This adds a functional option parameter to NewController to allow adding future configurations to control the behavior of Controller. This will come in handy for implementing features like the one in golang#22.
This minimal PR documents the installation command. It took me a moment to look it up from the github.com/golang repo. Hopefully this can help save a few moments for others. --------- Co-authored-by: Sung Yoon Whang <[email protected]>
Go reference uses module name rather than repository URL as a package name.
This is an initial implementation of the proposal outlined in this issue, golang#685
Now that we've released an initial version, update the README to reflect that.
migrate from golang#630 more: golang#622 golang#427 golang#634 golang#657 --------- Co-authored-by: Sung Yoon Whang <[email protected]>
kucherenkovova
force-pushed
the
invocation-arguments
branch
from
882955c
to
f7ed795
Compare
kucherenkovova
force-pushed
the
invocation-arguments
branch
from
f7ed795
to
23e5425
Compare
kucherenkovova
force-pushed
the
invocation-arguments
branch
from
23e5425
to
aa0d61f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #554