x/term: windows: arrow keys not received and thus history not working

[ldemailly]

Go version

go1.22.6

Output of go env in your module/workspace:

set GO111MODULE=
set GOARCH=amd64
set GOBIN=
set GOCACHE=C:\Users\l\AppData\Local\go-build
set GOENV=C:\Users\l\AppData\Roaming\go\env
set GOEXE=.exe
set GOEXPERIMENT=
set GOFLAGS=
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOINSECURE=
set GOMODCACHE=C:\Users\l\go\pkg\mod
set GONOPROXY=
set GONOSUMDB=
set GOOS=windows
set GOPATH=C:\Users\l\go
set GOPRIVATE=
set GOPROXY=https://proxy.golang.org,direct
set GOROOT=C:\Program Files\Go
set GOSUMDB=sum.golang.org
set GOTMPDIR=
set GOTOOLCHAIN=auto
set GOTOOLDIR=C:\Program Files\Go\pkg\tool\windows_amd64
set GOVCS=
set GOVERSION=go1.22.6
set GCCGO=gccgo
set GOAMD64=v1
set AR=ar
set CC=gcc
set CXX=g++
set CGO_ENABLED=0
set GOMOD=C:\Users\l\github\fortio.org\terminal\go.mod
set GOWORK=
set CGO_CFLAGS=-O2 -g
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-O2 -g
set CGO_FFLAGS=-O2 -g
set CGO_LDFLAGS=-O2 -g
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -fno-caret-diagnostics -Qunused-arguments -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=C:\Users\l\AppData\Local\Temp\go-build733720181=/tmp/go-build -gno-record-gcc-switches

What did you do?

run x/term based program on windows
(I can add sample program later)

the fix is easy, PR incoming

What did you see happen?

using arrow keys doesn't do anything on windows terminal

What did you expect to see?

arrow keys to move cursor and go up down in history

[gabyhelp]

Related Issues and Documentation

• x/sys/windows: Neither Read() nor ReadConsole() read special keys #44373 (closed)
• x/term: The handle is invalid on windows #68187 (closed)

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[gopherbot]

Change https://go.dev/cl/603960 mentions this issue: x/term: windows: fix arrow keys non functional (not received)

[cagedmantis]

cc @rsc

[ldemailly]

🎉 - when will it be tagged? is that a weekly thing?

[ianlancetaylor]

I think it's monthly these days.

[ldemailly]

Thanks! no rush, maybe it'll give time to get #68780 looked at and https://go-review.googlesource.com/c/term/+/603957 to happen too