-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bcrypt: document 72-byte password length limit #90
base: master
Are you sure you want to change the base?
Conversation
This BCrypt implementation supports a maximum password length of 73 characters. This was not documented prior which is resolved with this PR.
This PR (HEAD: 21f59bc) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/crypto/+/177818 to see it. Tip: You can toggle comments from me using the |
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/177818. |
This PR (HEAD: 313e465) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/crypto/+/177818 to see it. Tip: You can toggle comments from me using the |
This PR (HEAD: 79b0e9c) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/crypto/+/177818 to see it. Tip: You can toggle comments from me using the |
Anything else needed to get this merged? |
Message from Go Bot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/177818. |
Message from Aeneas Rekkas: Patch Set 6: Code-Review+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/177818. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/177818. |
Message from Aeneas Rekkas: Patch Set 6: Code-Review+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/177818. |
This BCrypt implementation supports a maximum password length of 72 characters. This was not documented prior which is resolved with this PR.