Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #453 #452 #454

Merged
merged 2 commits into from
Jul 11, 2024
Merged

fixes #453 #452 #454

merged 2 commits into from
Jul 11, 2024

Conversation

flbla
Copy link
Contributor

@flbla flbla commented Jul 11, 2024

fixes #453 #452

@flbla flbla requested a review from a team as a code owner July 11, 2024 12:07
Signed-off-by: flbla <[email protected]>
Copy link

sonarcloud bot commented Jul 11, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@flbla flbla merged commit 09b6bd6 into main Jul 11, 2024
13 of 15 checks passed
@flbla flbla deleted the hotfix/label-project branch July 11, 2024 12:20
@1337andre
Copy link
Contributor

Hi @flbla could it be, that with change this setting is not optional anymore?
With
deployment_security = ""
i got this error now

 Error: "deployment_security" must be one of [none, low, medium, high, critical], got 
│ 
│   with module.quay_io.harbor_project.this,
│   on .terraform/modules/quay_io/main.tf line 6, in resource "harbor_project" "this":
│    6:   deployment_security = var.deployment_security

@flbla
Copy link
Contributor Author

flbla commented Jul 29, 2024

hi @1337andre ,
it's still optional, but if you set the value to "", it's not allowed.
can you try with null instead of "" ?

example :

resource "harbor_project" "test" {
  name = "test12345"
  deployment_security = null
  auto_sbom_generation = true
}

@1337andre
Copy link
Contributor

thx for the quick answer! @flbla

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

harbor_project not detecting changes to some deployment security settings
2 participants