Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user login event to audit log #21415

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

stonezdj
Copy link
Contributor

Add common event handler
Register login event
Update previous audit log event redirect to auditlogext table

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner January 14, 2025 10:03
@stonezdj stonezdj added the release-note/new-feature New Harbor Feature label Jan 14, 2025
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.20%. Comparing base (c8c11b4) to head (119e075).
Report is 373 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #21415      +/-   ##
==========================================
+ Coverage   45.36%   46.20%   +0.83%     
==========================================
  Files         244      247       +3     
  Lines       13333    13883     +550     
  Branches     2719     2875     +156     
==========================================
+ Hits         6049     6414     +365     
- Misses       6983     7131     +148     
- Partials      301      338      +37     
Flag Coverage Δ
unittests 46.20% <ø> (+0.83%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 491 files with indirect coverage changes

@stonezdj stonezdj force-pushed the 25jan14_add_login_event branch 4 times, most recently from 1df7492 to 48d8446 Compare January 20, 2025 05:24
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj force-pushed the 25jan14_add_login_event branch from 48d8446 to 9cc4519 Compare January 21, 2025 02:41
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj force-pushed the 25jan14_add_login_event branch 3 times, most recently from 77b4763 to 9c3c3fd Compare January 23, 2025 07:03
  Add common event handler
  Register login event
  Update previous audit log event redirect to auditlogext table

Signed-off-by: stonezdj <[email protected]>
@stonezdj stonezdj force-pushed the 25jan14_add_login_event branch from 9c3c3fd to 119e075 Compare January 23, 2025 07:04
@stonezdj stonezdj merged commit f808f33 into goharbor:main Jan 23, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/new-feature New Harbor Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants