Fixes-21021 Display proxy cache in project configuration page #21048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21048 +/- ##
===========================================
+ Coverage 45.36% 66.09% +20.72%
===========================================
Files 244 1049 +805
Lines 13333 114645 +101312
Branches 2719 2867 +148
===========================================
+ Hits 6049 75776 +69727
- Misses 6983 34727 +27744
- Partials 301 4142 +3841
Flags with carried forward coverage won't be shown. Click here to find out more. |
bupd
reviewed
Oct 16, 2024
There was a problem hiding this comment.
Hello @xuelichao, I tested the changes on my local environment, and I noticed that the bandwidth is the same for all proxy cache projects, showing -1. I’ve made some changes to fix this so that the bandwidth is displayed correctly for each proxy cache project instead of -1 across the board.
src/portal/src/app/base/project/project-config/project-policy-config/project.ts
Outdated
Show resolved
Hide resolved
| @@ -21,6 +22,7 @@ export class Project { | |||
| auto_scan: string | boolean; | |||
| auto_sbom_generation: string | boolean; | |||
| reuse_sys_cve_allowlist?: string; | |||
| bandwidth?: number | null; | |||
There was a problem hiding this comment.
Suggested change
| bandwidth?: number | null; | |
| proxy_speed_kb?: number | null; |
...src/app/base/project/project-config/project-policy-config/project-policy-config.component.ts
Outdated
Show resolved
Hide resolved
stonezdj
approved these changes
Oct 17, 2024
Signed-off-by: xuelichao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display proxy cache in project configuration page
Issue being fixed
Fixes #21021
This PR Only supports to display the values:
Please indicate you've done the following: