-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove robotV1 from code base (#20958) #20991
base: main
Are you sure you want to change the base?
Conversation
I am unsure which label should be applied since it's the removal of a deprecated API. I would guess |
@sgaist please help to resolve the conflict, thanks. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20991 +/- ##
===========================================
+ Coverage 45.36% 65.99% +20.62%
===========================================
Files 244 1048 +804
Lines 13333 113539 +100206
Branches 2719 2856 +137
===========================================
+ Hits 6049 74930 +68881
- Misses 6983 34474 +27491
- Partials 301 4135 +3834
Flags with carried forward coverage won't be shown. Click here to find out more.
|
It was deprecated in 2.4.0. Signed-off-by: Samuel Gaist <[email protected]>
132a960
to
7189f36
Compare
Solved ! |
since, we're in the release cycle of v2.12. I will merge it after we branch v2.12, thanks. |
@wy65701436 Sure thing ! In between, would you be so kind and add the |
This PR remove the deprecated robotV1 code and endpoint.
It was deprecated in 2.4.0.
Issue being fixed
Fixes #20958
Please indicate you've done the following: