Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated internationalisation : fr-fr #19915

Merged
merged 5 commits into from
Feb 11, 2024
Merged

Conversation

tostt
Copy link
Contributor

@tostt tostt commented Jan 26, 2024

Comprehensive Summary of your change

Edited file fr-fr-lang.json:

  • Sorted keys the same way as in en-us-lang.json
  • Removed keys that are not present in en-us-lang.json
  • Translated new strings into French

Due to the nature of the changes, no build or test of the application was performed.

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@tostt tostt requested a review from a team as a code owner January 26, 2024 14:11
@Vad1mo Vad1mo added release-note/enhancement Label to mark PR to be added under release notes as enhancement area/i18n Related to Translation changes. labels Jan 26, 2024
@Vad1mo Vad1mo enabled auto-merge (squash) January 26, 2024 21:52
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a3e1b1e) 67.45% compared to head (eff5b11) 67.45%.
Report is 8 commits behind head on main.

❗ Current head eff5b11 differs from pull request most recent head 9e7f08d. Consider uploading reports for the commit 9e7f08d to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #19915   +/-   ##
=======================================
  Coverage   67.45%   67.45%           
=======================================
  Files         996      996           
  Lines      109773   109773           
  Branches     2720     2720           
=======================================
+ Hits        74044    74051    +7     
+ Misses      31747    31741    -6     
+ Partials     3982     3981    -1     
Flag Coverage Δ
unittests 67.45% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

@wy65701436 wy65701436 added the help wanted The issues that is valid but needs help from community label Jan 29, 2024
src/portal/src/i18n/lang/fr-fr-lang.json Outdated Show resolved Hide resolved
src/portal/src/i18n/lang/fr-fr-lang.json Show resolved Hide resolved
src/portal/src/i18n/lang/fr-fr-lang.json Show resolved Hide resolved
src/portal/src/i18n/lang/fr-fr-lang.json Outdated Show resolved Hide resolved
src/portal/src/i18n/lang/fr-fr-lang.json Outdated Show resolved Hide resolved
auto-merge was automatically disabled February 7, 2024 12:36

Head branch was pushed to by a user without write access

Copy link
Contributor

@thcdrt thcdrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM

@Vad1mo Vad1mo enabled auto-merge (squash) February 11, 2024 13:45
tostt and others added 5 commits February 11, 2024 14:45
Edited file fr-fr-lang.json:
- Translation of new strings in French
- Entries have been sorted the same way as en-us-lang.json

Signed-off-by: tostt <[email protected]>
Corrections

Signed-off-by: tostt <[email protected]>
Co-authored-by: Thomas Coudert <[email protected]>
Signed-off-by: tostt <[email protected]>
Co-authored-by: Thomas Coudert <[email protected]>
Signed-off-by: tostt <[email protected]>
@Vad1mo Vad1mo merged commit 0e58083 into goharbor:main Feb 11, 2024
10 checks passed
@tostt tostt deleted the feat/i18n-fr-fr branch February 12, 2024 09:59
@OrlinVasilev
Copy link
Member

@tostt congrats on merging that first PR here and now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/i18n Related to Translation changes. help wanted The issues that is valid but needs help from community release-note/enhancement Label to mark PR to be added under release notes as enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants