Fix : Incorrect MongoDB Connection Logs

pkg/gofr/datasource/mongo/mongo.go

@@ -4,6 +4,7 @@ import (
 	"context"
 	"errors"
 	"fmt"
+	"net/url"
 	"time"
 
 	"go.opentelemetry.io/otel/attribute"
@@ -83,13 +84,23 @@ func (c *Client) UseTracer(tracer any) {
 
 // Connect establishes a connection to MongoDB and registers metrics using the provided configuration when the client was Created.
 func (c *Client) Connect() {
-	c.logger.Debugf("connecting to MongoDB at %v to database %v", c.config.URI, c.config.Database)
+	var host string
+
+	c.logger.Debugf("connecting to MongoDB at %v to database %v", c.config.Host, c.config.Database)
 
 	uri := c.config.URI
 
 	if uri == "" {
 		uri = fmt.Sprintf("mongodb://%s:%s@%s:%d/%s?authSource=admin",
 			c.config.User, c.config.Password, c.config.Host, c.config.Port, c.config.Database)
+
+		host = c.config.Host
+	} else {
+		host = getDBHost(uri)
+
+		if host == "" {
+			c.logger.Debug("failed to parse URI: incorrect format provided")
+		}
 	}
 
 	timeout := c.config.ConnectionTimeout
@@ -108,18 +119,27 @@ func (c *Client) Connect() {
 	}
 
 	if err = m.Ping(ctx, nil); err != nil {
-		c.logger.Errorf("could not connect to mongoDB at %v due to err: %v", c.config.URI, err)
+		c.logger.Errorf("could not connect to mongoDB at %v due to err: %v", host, err)
 		return
 	}
 
-	c.logger.Logf("connected to mongoDB successfully at %v to database %v", c.config.URI, c.config.Database)
+	c.logger.Logf("connected to mongoDB successfully at %v to database %v", host, c.config.Database)
 
 	mongoBuckets := []float64{.05, .075, .1, .125, .15, .2, .3, .5, .75, 1, 2, 3, 4, 5, 7.5, 10}
 	c.metrics.NewHistogram("app_mongo_stats", "Response time of MONGO queries in milliseconds.", mongoBuckets...)
 
 	c.Database = m.Database(c.config.Database)
 
-	c.logger.Logf("connected to MongoDB at %v to database %v", uri, c.Database)
+	c.logger.Logf("connected to MongoDB at %v to database %v", host, c.Database)
+}
+
+func getDBHost(uri string) (host string) {
+	parsedURL, err := url.Parse(uri)
+	if err != nil {
+		return ""
+	}
+
+	return parsedURL.Hostname()
 }
 
 // InsertOne inserts a single document into the specified collection.

pkg/gofr/datasource/mongo/mongo_test.go

@@ -36,6 +36,47 @@ func Test_NewMongoClient(t *testing.T) {
 	assert.NotNil(t, client)
 }
 
+func TestGetDBHost(t *testing.T) {
+	tests := []struct {
+		name     string
+		uri      string
+		expected string
+	}{
+		{
+			name:     "Valid URI with host and port",
+			uri:      "mongodb://username:password@hostname:27017/database?authSource=admin",
+			expected: "hostname",
+		},
+		{
+			name:     "Valid URI with IP address as host",
+			uri:      "mongodb://username:[email protected]:27017/database?authSource=admin",
+			expected: "192.168.1.1",
+		},
+		{
+			name:     "Invalid URI with no host",
+			uri:      "mongodb://username:password@:27017/database?authSource=admin",
+			expected: "",
+		},
+		{
+			name:     "Empty URI",
+			uri:      "",
+			expected: "",
+		},
+		{
+			name:     "Malformed URI",
+			uri:      "mongodb:/username:password@hostname:27017/database?authSource=admin",
+			expected: "",
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			result := getDBHost(tt.uri)
+			assert.Equal(t, tt.expected, result, "Test case: %s", tt.name)
+		})
+	}
+}
+
 func Test_NewMongoClientError(t *testing.T) {
 	ctrl := gomock.NewController(t)
 	defer ctrl.Finish()
@@ -46,7 +87,7 @@ func Test_NewMongoClientError(t *testing.T) {
 	logger.EXPECT().Debugf("connecting to MongoDB at %v to database %v", "mongo", "test")
 	logger.EXPECT().Errorf("error while connecting to MongoDB, err:%v", gomock.Any())
 
-	client := New(Config{URI: "mongo", Database: "test"})
+	client := New(Config{Host: "mongo", Database: "test"})
 	client.UseLogger(logger)
 	client.UseMetrics(metrics)
 	client.Connect()