review suggestions

gofr-dev · Jan 8, 2025 · c200644 · c200644
1 parent 6ad8948
commit c200644
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 4 deletions.
diff --git a/pkg/gofr/datasource/mongo/mongo.go b/pkg/gofr/datasource/mongo/mongo.go
@@ -166,7 +166,7 @@ func generateMongoURI(config *Config) (uri, host string, err error) {
 }
 
 func getDBHost(uri string) (host string, err error) {
-	parsedURL, err := url.Parse(uri)
+	parsedURL, err := url.ParseRequestURI(uri)
 	if err != nil {
 		return "", err
 	}

diff --git a/pkg/gofr/datasource/mongo/mongo_test.go b/pkg/gofr/datasource/mongo/mongo_test.go
@@ -48,12 +48,23 @@ func TestGenerateMongoURI(t *testing.T) {
 			name: "Valid Config",
 			config: Config{
 				User:     "admin",
-				Password: "password",
+				Password: "p@##word:",
 				Host:     "localhost",
 				Port:     27017,
 				Database: "mydb",
 			},
-			expectedURI:   "mongodb://admin:password@localhost:27017/mydb?authSource=admin",
+			expectedURI:   "mongodb://admin:p%2540%2523%2523word%253A@localhost:27017/mydb?authSource=admin",
+			expectedHost:  "localhost",
+			expectedError: "",
+		},
+		{
+			name: "Valid Config without authentication",
+			config: Config{
+				Host:     "localhost",
+				Port:     27017,
+				Database: "mydb",
+			},
+			expectedURI:   "mongodb://localhost:27017/mydb?authSource=admin",
 			expectedHost:  "localhost",
 			expectedError: "",
 		},
@@ -150,7 +161,7 @@ func TestGetDBHost(t *testing.T) {
 			name:        "Empty URI",
 			uri:         "",
 			expected:    "",
-			expectedErr: "incorrect URI for MongoDB",
+			expectedErr: "parse \"\": empty url",
 		},
 		{
 			name:        "Malformed URI",