Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin Does not support Godot 4.0 and higher update README #61

Closed
wants to merge 0 commits into from
Closed

Plugin Does not support Godot 4.0 and higher update README #61

wants to merge 0 commits into from

Conversation

Dantali0n
Copy link
Contributor

This really simple patch will go a long way for end users.

fanjin-z
fanjin-z approved these changes Dec 21, 2023
View reviewed changes
Copy link

@fanjin-z fanjin-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! As discussed in #43, 4.0 won't be supported soon, this could clear up some confusion

raulsntos
raulsntos reviewed Jan 26, 2024
View reviewed changes
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I totally missed this PR. It seems like a good compromise until we update the extension which may still take a while.

README.md Outdated Show resolved Hide resolved
@raulsntos raulsntos added the documentation Improvements or additions to documentation label Jan 26, 2024
raulsntos
raulsntos approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@Dantali0n
Copy link
Contributor Author

Dantali0n commented Feb 28, 2024 •
edited
Loading

Anything I can do to help this along? someone I could ping on email / irc etc?

@raulsntos raulsntos closed this Feb 29, 2024
raulsntos added a commit that referenced this pull request Feb 29, 2024
@raulsntos
Merge pull request #61 from Dantali0n/master
55efe21
@raulsntos
Copy link
Member

Sorry, I messed up the rebase but the PR got merged in 7ab1157

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fanjin-z fanjin-z fanjin-z approved these changes

@raulsntos raulsntos raulsntos approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dantali0n @raulsntos @fanjin-z