Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CanGetNewInstanceTrait #702

Merged
merged 5 commits into from
Aug 26, 2024
Merged

Add CanGetNewInstanceTrait #702

merged 5 commits into from
Aug 26, 2024

Conversation

agibson-godaddy
Copy link
Contributor

@agibson-godaddy agibson-godaddy commented Aug 23, 2024 •
edited
Loading

Summary

Release: #699

This adds the CanGetNewInstanceTrait

QA

  • Code review
  • Checks pass

Before merge

  • I have confirmed these changes in each supported minor WooCommerce version

@agibson-godaddy agibson-godaddy changed the title Add new traits (CanGetNewInstanceTrait, CanConvertToArrayTrait) Add CanGetNewInstanceTrait Aug 23, 2024
@agibson-godaddy agibson-godaddy marked this pull request as ready for review August 23, 2024 11:16
nmolham-godaddy
nmolham-godaddy approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@nmolham-godaddy nmolham-godaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LVGTM, I just replaced the class reflection with the usage of the spread operator instead for better performance

@nmolham-godaddy nmolham-godaddy merged commit 7145b7e into release/5.13.1 Aug 26, 2024
5 checks passed
@nmolham-godaddy nmolham-godaddy deleted the chore/add-new-traits branch August 26, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmolham-godaddy nmolham-godaddy nmolham-godaddy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agibson-godaddy @nmolham-godaddy