Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IsSingletonTrait #700

Merged
merged 5 commits into from
Aug 23, 2024
Merged

Conversation

nmolham-godaddy
Copy link
Contributor

@nmolham-godaddy nmolham-godaddy commented Aug 22, 2024

Summary

Adds IsSingletonTrait trait.

Suggested by @agibson-godaddy https://github.com/gdcorp-partners/woocommerce-gateway-cybersource/pull/149#discussion_r1724878272

Release: #699

QA

  • Code review
  • Checks pass

Before merge

  • I have confirmed these changes in each supported minor WooCommerce version

@nmolham-godaddy nmolham-godaddy self-assigned this Aug 22, 2024
@nmolham-godaddy nmolham-godaddy requested a review from a team August 22, 2024 03:05
@agibson-godaddy agibson-godaddy changed the base branch from master to release/5.13.1 August 22, 2024 13:41
Copy link
Contributor

@agibson-godaddy agibson-godaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a tiny thing.

woocommerce/Traits/IsSingletonTrait.php Outdated Show resolved Hide resolved
@agibson-godaddy agibson-godaddy merged commit 604225c into release/5.13.1 Aug 23, 2024
5 checks passed
@agibson-godaddy agibson-godaddy deleted the chore/add-is-singleton-trait branch August 23, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants