Update func isDomainAllowed #420
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
like scrapy. if c.Visit("http://www.xxxx.com.cn/"), colly.AllowedDomains("xxxx.com.cn") should be work for main domain. so if we request 'www.xxxx.com.cn' and AllowedDomains are 'xxxx.com.cn'. This means that we have access to all subdomains under the top-level domain name
belintani
reviewed
Dec 21, 2019
| @@ -693,6 +693,11 @@ func (c *Collector) isDomainAllowed(domain string) bool { | |||
| if c.AllowedDomains == nil || len(c.AllowedDomains) == 0 { | |||
| return true | |||
| } | |||
| for _, d2 := range c.AllowedDomains { | |||
| if strings.Contains(domain, d2) { | |||
There was a problem hiding this comment.
I recommend to use "HasSuffix" method instead of "Contains". Does that make sense?
There was a problem hiding this comment.
HasSuffix sounds better for me, could you change it? Also, please update the docstring with the new behavior.
|
This is a great change, I was just looking for a good solution for this issue. 👍 |
|
Any update about this? ... |
|
I dunno, this is a pretty breaking change. Depending on your use case, you might want this behaviour, or not. In any case, one can do arbitrary origin check of the URL just before calling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
like scrapy. if c.Visit("http://www.xxxx.com.cn/"), colly.AllowedDomains("xxxx.com.cn") should be work for main domain. so if we request 'www.xxxx.com.cn' and AllowedDomains are 'xxxx.com.cn'. This means that we have access to all subdomains under the top-level domain name