Try to fix sv-benchmarks termination-restricted-15/IntPath Apron normalization #1585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As identified in #1576 (comment), this SV-COMP task causes a weird both branches dead situation which actually is sound. With both octagon and polyhedra, there are constraints like
2x=1wherexis an integer. Neither domain seems to immediately reduce this to bottom to make it dead.Only later when re-asserting some (even the same) constraint, it's somehow checked again and does become dead, but in both branches.
Here are a few attempts to try to make this come out early, but I don't think none are particularly nice. It's hard to tell where Apron actually applies some integer reduction. It seems to be a separate thing from other kinds of normalization/closure/canonicalization that Apron has and does.