Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full EL Reward Support + Search for Validators via WithdrawalCredentials/Address #255

Merged
merged 22 commits into from
Nov 3, 2023
Merged

Full EL Reward Support + Search for Validators via WithdrawalCredentials/Address #255

merged 22 commits into from
Nov 3, 2023

Conversation

manuelsc
Copy link
Collaborator

Adds feature from #137
Fixes issue #251

@manuelsc manuelsc changed the base branch from main to gnosis October 25, 2023 12:14
@D13ce D13ce mentioned this pull request Oct 31, 2023
Merged
D13ce
D13ce requested changes Oct 31, 2023
View reviewed changes
src/app/components/dashboard/dashboard.component.ts Outdated Show resolved Hide resolved
src/app/components/dashboard/dashboard.component.ts Outdated Show resolved Hide resolved
src/app/requests/requests.ts Show resolved Hide resolved
src/app/services/unitconv.service.ts Outdated Show resolved Hide resolved
src/app/tab-validators/tab-validators.page.html Outdated Show resolved Hide resolved
src/app/components/dashboard/dashboard.component.ts Outdated Show resolved Hide resolved
src/app/components/dashboard/dashboard.component.html Show resolved Hide resolved
src/app/components/dashboard/dashboard.component.html Show resolved Hide resolved
src/app/components/dashboard/dashboard.component.html Outdated Show resolved Hide resolved
src/app/components/dashboard/dashboard.component.html Show resolved Hide resolved
D13ce
D13ce approved these changes Nov 3, 2023
View reviewed changes
Copy link
Collaborator

@D13ce D13ce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

One problem was found, will create an internal ticket for it.

@manuelsc manuelsc merged commit bf87e5a into gnosis Nov 3, 2023
@manuelsc manuelsc deleted the full-el-rewards branch November 7, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@D13ce D13ce D13ce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manuelsc @D13ce