Set node version requirement #468
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node 18 introduces prefix-only node packages, e.g. `node:path`. Using this package on Node 18+ results in errors because the imports are not prefixed. See https://stateful.com/blog/node-18-prefix-only-modules and the previous attempt to introduce this goatandsheep#399
IgorNadj
added a commit
to beyondessential/tupaia
that referenced
this pull request
Oct 23, 2023
Tried v20 but node 18 has breaking changes which break react-native-dotenv, see goatandsheep/react-native-dotenv#468
IgorNadj
added a commit
to beyondessential/tupaia
that referenced
this pull request
Oct 30, 2023
Tried v20 but node 18 has breaking changes which break react-native-dotenv, see goatandsheep/react-native-dotenv#468
IgorNadj
added a commit
to beyondessential/tupaia
that referenced
this pull request
Oct 30, 2023
Tried v20 but node 18 has breaking changes which break react-native-dotenv, see goatandsheep/react-native-dotenv#468
IgorNadj
added a commit
to beyondessential/tupaia
that referenced
this pull request
Nov 3, 2023
Tried v20 but node 18 has breaking changes which break react-native-dotenv, see goatandsheep/react-native-dotenv#468
IgorNadj
added a commit
to beyondessential/tupaia
that referenced
this pull request
Nov 6, 2023
Tried v20 but node 18 has breaking changes which break react-native-dotenv, see goatandsheep/react-native-dotenv#468
IgorNadj
added a commit
to beyondessential/tupaia
that referenced
this pull request
Nov 24, 2023
* Prerequisite: node v16+ (selected v16.20.2) Tried v20 but node 18 has breaking changes which break react-native-dotenv, see goatandsheep/react-native-dotenv#468 * npx react-native@latest init TupaiaMediTrak * Rename new package, add to workspace, nohoist it * Add info for devs in README * cp -r meditrak-app/app meditrak-app-new/app * find . -name '*.js' -exec sh -c 'mv -zsh -zsh.jsx' {} \; * Copy project root files from meditrak-app to meditrak-app-new * Rm meditrak-app/package.json. This was needed because trying to install newer versions of tools e.g. node-gpy was not working while older versions were already installed + each runs on different versions of node. * Copy package.json deps from meditrak-app to meditrak-app-new * Rm deprecated packages * Fix nanoid import after upgrade * Temporarily stub out appcenter and bugsnag * Rm unused package-lock.json * Add missing package @babel/plugin-proposal-export-default-from * Swap react-native-dotenv out for react-native-config react-native-dotenv wasnt working with node 16 * Fix module resolution * Upgrade Realm model definitions for new version * Add missing peer deps * Bump version * Minor: Ignore react warnings These will need to be dealt with in an upgrade to the app itself * Re-setup react-native-vector-icons * Reimplement QR code scan Using new non-deprecated package react-native-vision-camera * Downgrade nanoid to restore functionality * Copy over all permissions from old app AndroidManifest * Fix nanoid import * Update PhotoQuestion for upgraded react-native-image-picker * Fix icon * Minor: Add notes on env vars and reset-cache script * Setup ios: Copy config from old app, version number * Set app name and icons * Bump node version * rm -fr packages/meditrak-app && mv packages/meditrak-app-new packages/meditrak-app * Rename @tupaia/meditrak-app-new to @tupaia/meditrak-app * Fix android build on AppCenter * Hack: use node14 for meditrak-app only Node will be bumped globally in RN-1090 * RN-963 Meditrak ios features (#5143) * Save QR codes to camera roll * Set BES as the dev team for the ios app XCode > Signing & Capabilities * Typo * Rm unused package react-native-file-access * Bump version * Update iOS Encryption compliance See https://stackoverflow.com/a/46691541 MediTrak does use encryption (HTTPS api calls), but is exempt from Exporter Registration and Reporting (ERN) process, see https://stackoverflow.com/a/16080233 * Bump version * Bump Meditrak App version * Add missing dep * Bump Meditrak version * Fix build issue by removing global package:build:react-scripts, setting specific yargs version at top level * Add dep directly to fix babel error * Add dep directly to fix build issue * Add missing dep * Add missing deps * Add missing deps for ui-map-components * Lock down @babel/types version Fixes issue with incompatible versions clashing, see babel/babel#15765 (comment) * Reimplement Bugsnag * Reimplement Appcenter analytics * Bump version * Fix bugsnag config, pod install * Remove RN launch screen text * Bump version * Add missing nvmrc * Bump realm to fix install issue * Rm obsolete resolutions override * Bump version
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Unfortunately I tried this and it caused a lot of issues so I reverted. The paths not being resolved is likely not an issue with the way the library is built. I'm happy however to help you with your bug. Please share code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node 18 introduces prefix-only node packages, e.g.
node:path. Using this package on Node 18+ results in errors because the imports cannot be resolved.See https://stateful.com/blog/node-18-prefix-only-modules and the previous attempt to introduce this #399
I suggest creating a 4. version of this package that supports 18+ as a solution which covers all node versions.
Link to issue
Small enough I thought it doesn't need it