Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4 Baking and Endorsing Fixes #181

Open
wants to merge 57 commits into
base: master
Choose a base branch
from

Conversation

utdrmac
Copy link
Contributor

@utdrmac utdrmac commented Jan 22, 2021

Fixes #177
Summary of changes:

  • Added contructRPCOptions() to MinimalValidTimeInput and thus to MinimalValidTime(). Prior to this, the RPC did not receive important information such as the endorsing_power, nor priority of the block in question. This returned invalid time period.
  • Change Constants.TimeBetweenBlocks to be IntArray so that JSON unmarshal would properly parse to Ints
  • ^^Similar, Constants.ProofOfWorkThreshold
  • ForgeBlockHeaderBody.Proto was a string and should be Int
  • p.Timestamp.String() returns non-RPC compliant timestamp; should be unix timestamp
  • SeedNonceHash should not be present when preapplying a block if no nonce hash is needed
  • InjectionBlockInput - This struct originally wanted a *Block but this type does not marshal down to what is required by the RPC. The RPC only wants the signature + shell header of the constructed block ("data") + operations to include in block ("operations"). The easiest way I saw to do this was to simply build an anonymous struct just before injecting.
  • Add func and associated helpers/structs to pull operations from mempool

DefinitelyNotAGoat and others added 30 commits August 3, 2019 16:19
This commit adds the ability to GetReport by the projected
earnings and not what was actually earned.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

README example does not work as-is
2 participants