cors: always return 204 for a matched preflight #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it could return a 404, etc. This had the effect of in the browser producting a network error because the preflight request failed.
|
So this will still end up having the 404 issue because it specifically mounts to existing routes. But it will avoid other issues with a middleware returning a 401, etc. |
0syntrax0
approved these changes
Oct 27, 2023
|
Looks great, thank you! |
|
I tested this locally and am now seeing 204 instead of 200 and it is working in the browser |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it could return a 404, etc.
This had the effect of in the browser producting a network error because the preflight request failed.
These changes are passing the test suite but are not yet manually tested.