Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add web support #70

Merged
merged 3 commits into from
Apr 29, 2024
Merged

Conversation

denysvitali
Copy link
Contributor

@denysvitali denysvitali commented Apr 5, 2024

Depends on #69 (stacked PR, the diff is going to be huge until #69 is merged, just review 5b82a47)

This PR adds support for the web platform to make it easier to develop the app further. Eventually, this could be a second frontend to Vikunja - although this is not really the reason why I'm doing this.

With this PR, I've also fixed an issue that was seen during Hot Reload in the web, where the theme was not correctly reset.

@denysvitali denysvitali force-pushed the feature/add-web-support branch 2 times, most recently from 939089a to 5b82a47 Compare April 5, 2024 13:32
@denysvitali denysvitali mentioned this pull request Apr 5, 2024
@Benimautner
Copy link
Collaborator

I think it's fine to have it, but since Vikunja already has a great web frontend with a lot more features, I don't really see a reason to add (and then maintain) this.

@Benimautner Benimautner requested review from Benimautner and kolaente and removed request for Benimautner April 6, 2024 22:30
@denysvitali
Copy link
Contributor Author

For me the biggest advantage is to be able to develop the features locally with Chrome (or Chromium).

We can maybe keep this target enabled but without officially supporting it

@Benimautner
Copy link
Collaborator

Benimautner commented Apr 7, 2024

What do you mean by developing locally with chrome? The official frontend is in Vue, you can develop that there, too, no?

We could, but it's just not what I would use flutter for for vikunja. @kolaente let me know what you think pls

Edit: nevermind, I just realized you probably mean the features for the flutter app. You're obviously right, we can definitely keep it in for that!

@kolaente
Copy link
Member

kolaente commented Apr 7, 2024

Similar to what Beni said, we won't use the flutter web app as a replacement for the current web frontend anytime soon. I think having an easy way to develop for it without requiring a full-blown Android dev environment is a very good thing.

Can you add a note to the readme about how to get started with flutter web and how we'll only use it for development?

@Benimautner Benimautner merged commit 9961447 into go-vikunja:main Apr 29, 2024
2 checks passed
@Benimautner
Copy link
Collaborator

The Readme is on my todo list anyways, so I'ma just add this when I update it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants