Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix file URL validator #1171

Merged
merged 1 commit into from
Nov 4, 2023
Merged

fix file URL validator #1171

merged 1 commit into from
Nov 4, 2023

Conversation

nodivbyzero
Copy link
Contributor

Fixes Or Enhances

This PR adds an additional check for the file URL schema.
Connected to #1165

Make sure that you've checked the boxes below before you submit PR:

  • Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

@nodivbyzero nodivbyzero requested a review from a team as a code owner September 20, 2023 01:36
@coveralls
Copy link

Coverage Status

coverage: 73.864% (+0.02%) from 73.849% when pulling ed3b911 on nodivbyzero:file-url-validator-fix into 8d50f2f on go-playground:master.

deankarn
deankarn approved these changes Nov 4, 2023
View reviewed changes
Copy link
Contributor

@deankarn deankarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deankarn deankarn merged commit c856961 into go-playground:master Nov 4, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deankarn deankarn deankarn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nodivbyzero @coveralls @deankarn