Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update data from CLDR v32 to v34. #34

Closed
wants to merge 2 commits into from

Conversation

bojanz
Copy link
Contributor

@bojanz bojanz commented Nov 6, 2020

Here's an attempt to do #33 in pieces. Instead of going to v38 we first go to v34. I tried v35.1 but it didn't generate cleanly.

There was one failing test, ru-RU.go:

 --- FAIL: TestFmtTimeFull (0.00s)
    ru_RU_test.go:858: Expected '9:05:01 Восточная Америка, стандартное время' Got '09:05:01 Восточная Америка, стандартное время'
--- FAIL: TestFmtTimeLong (0.00s)
    ru_RU_test.go:889: Expected '9:05:01 EST' Got '09:05:01 EST'
--- FAIL: TestFmtTimeMedium (0.00s)
    ru_RU_test.go:915: Expected '9:05:01' Got '09:05:01'
--- FAIL: TestFmtTimeShort (0.00s)
    ru_RU_test.go:941: Expected '9:05' Got '09:05'
FAIL

Fixed in a followup commit. The build is now green.

@bojanz
Copy link
Contributor Author

bojanz commented Nov 6, 2020

Huh. v35.1 didn't work, but v36.1 did. Closing this PR in favor of #35.

@bojanz bojanz closed this Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant