Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #42: Check on Ptr of Struct too strict? #43

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

kPshi
Copy link

@kPshi kPshi commented Aug 11, 2017

Fix to several common ptr/interface/struct chains as they came up here.

Basically I removed the restriction from being a *struct or *map to something that .CanSet() and also fill up the elements when necessary.

Separated tests and fix so that one can see that
a) circumstances where the issue appears are not overly complicated and break things
b) even with unmodified tests the fix works fine

@coveralls
Copy link

coveralls commented Aug 11, 2017

Coverage Status

Coverage increased (+0.2%) to 89.504% when pulling 90cec8f on kPshi:master into e984ee9 on go-ozzo:master.

@kPshi
Copy link
Author

kPshi commented Jun 21, 2018

Pulled changes. Maybe you want to accept the pull request before even more conflicts occur.

@kPshi kPshi mentioned this pull request Aug 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants