Series & Dataframe append/insert at a given position #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kniren
requested changes
Jan 20, 2020
Comment on lines
+281
to
+286
| s.elements = append(s.elements.(stringElements)[:pos], append(news.elements.(stringElements), s.elements.(stringElements)[pos:]...)...) | ||
| case Int: | ||
| s.elements = append(s.elements.(intElements)[:pos], append(news.elements.(intElements), s.elements.(intElements)[pos:]...)...) | ||
| case Float: | ||
| s.elements = append(s.elements.(floatElements)[:pos], append(news.elements.(floatElements), s.elements.(floatElements)[pos:]...)...) | ||
| case Bool: |
There was a problem hiding this comment.
It doesn't look like you have used gofmt on this code. Please run it on save before pushing.
There was a problem hiding this comment.
Funny, gofmt is producing this output for me. what do you suggest?
|
If you resolve the conflicts currently present, I'll just merge this. |
|
@mannharleen any ETA on this maybe? I'll gladly use your changes 😄 |
|
Sorry both for the delays. Kniren and my timings were off. I ll take a look over the weekend. |
…st) (#1) * Set up TravisCI * Make fixColnames faster (go-gota#112) Co-authored-by: Carl Kingsford <[email protected]> * Add dataframe.Concat (go-gota#104) Concat concatenates rows of two dataframes like RBind, but also includes the unmatched columns. * Combining filters with AND and user-defined filters (go-gota#99) * added missing closing brace in series/series.go (function Map) * removed empty line at beginning of function series/series.go/Map * implemented user-defined comparator for series' * added and semantics for row filtering with multiple filters * refined README for filtering with OR, AND, and user-defined filters (CompFunc) * Run go mod tidy * Add extra checks for TravisCI * Use UseNumber() when parsing JSON to interface{} (go-gota#116) * Add ReadHTML to support loading HTML tables (go-gota#107) * Allow numeric column-index for filters (go-gota#106) Co-authored-by: Alex Sanchez <[email protected]> Co-authored-by: gmarcais <[email protected]> Co-authored-by: Carl Kingsford <[email protected]> Co-authored-by: Mura Li <[email protected]> Co-authored-by: Christoph Laaber <[email protected]> Co-authored-by: gautamoncloud9 <[email protected]>
|
Thanks Julien. For the PR |
|
There seems to still have conflicts, probably still need rebasing.
I guess it should show the dev branch there instead. EDIT: Should be fixed with rebasing: mannharleen#2 😄 |
Closed
|
Any update？ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #73 #69
A method called "Insert" has been added to enable appending to an existing Series or Dataframe at a given position.
Open on how to improve the implementation.